Thread (42 messages) 42 messages, 7 authors, 2016-06-15

Re: [PATCH 02/16] sha1_file: refactor into `find_pack_object_pos`

flat view

From: Thomas Rast <hidden>
Date: 2016-06-15 22:57:55

Vicent Marti [off-list ref] writes:
quoted hunk ↗ jump to hunk
 	if (use_lookup) {
-		int pos = sha1_entry_pos(index, stride, 0,
-					 lo, hi, p->num_objects, sha1);
-		if (pos < 0)
-			return 0;
-		return nth_packed_object_offset(p, pos);
+		return sha1_entry_pos(index, stride, 0, lo, hi, p->num_objects, sha1);
 	}
Our house style prefers not having the braces in a single-line conditional.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help