Thread (2 messages) 2 messages, 2 authors, 2016-06-15

Re: [PATCH v14 05/16] Refactor write_name_quoted_relative, remove unused params

flat view

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:54

Jiang Xin [off-list ref] writes:
quoted hunk
-static void write_name(const char* name, size_t len)
+static void write_name(const char *name)
 {
-	write_name_quoted_relative(name, len, prefix, prefix_len, stdout,
-			line_terminator);
+
+	/* turn off prefix, if run with "--full-name" */
+	write_name_quoted_relative(name, prefix_len ? prefix : NULL,
+				   stdout, line_terminator);
Hmmm....

Does this mean that ls-files has been broken in 03/16, because
write_name_quoted_relative() was made to ignore prefix_len and
measure the length of prefix with strlen(prefix), and this change
fixes it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help