Re: [PATCH 02/16] t/t5505-remote: test push-refspec in branches-file
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:52
Ramkumar Ramachandra [off-list ref] writes:
quoted hunk
The test "migrate a remote from named file in $GIT_DIR/branches" reads the branches-file, but only checks that the url and fetch-refspec are set correctly. Check that the push-refspec is also set correctly. Signed-off-by: Ramkumar Ramachandra <redacted> --- t/t5505-remote.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index 4d5810f..38c62ec 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh@@ -698,7 +698,8 @@ test_expect_success 'migrate a remote from named file in $GIT_DIR/branches' ' git remote rename origin origin && ! test -f .git/branches/origin && test "$(git config remote.origin.url)" = "$origin_url" && - test "$(git config remote.origin.fetch)" = "refs/heads/master:refs/heads/origin" + test "$(git config remote.origin.fetch)" = "refs/heads/master:refs/heads/origin" && + test "$(git config remote.origin.push)" = "HEAD:refs/heads/master"
OK. That is an ancient "Cogito-compatible push" which might not be a sensible setting, but there is no point changing it now, and there is a value in making sure it will stay working the way it has. Good.
) '