Thread (11 messages) flat view 11 messages, 2 authors, 2016-06-15

Re: HTTP tests fail on OS X

From: Jeff King <hidden>
Date: 2016-06-15 22:57:51
Subsystem: the rest · Maintainer: Linus Torvalds

On Fri, Jun 21, 2013 at 12:27:02AM -0400, Brian Gernhardt wrote:
I've bisected it to this commit:
quoted
commit 0442743810c6f6c14386a5a9d6bf8e4d69adbc51
Author: Jeff King [off-list ref]
Date:   Sun Jun 9 04:07:59 2013 -0400

    t/lib-httpd/apache.conf: do not use LockFile in apache >= 2.4
OS X 10.8.4, apache 2.2.22
Hrm. That's quite odd. The patch in its entirety looks like this:
diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
index 542241b..891edd7 100644
--- a/t/lib-httpd/apache.conf
+++ b/t/lib-httpd/apache.conf
@@ -1,5 +1,7 @@ LockFile accept.lock
 ServerName dummy
+<IfVersion < 2.4>
 LockFile accept.lock
+</IfVersion>
 PidFile httpd.pid
 DocumentRoot www
So it should not be having any effect at all on apache 2.2, unless it
somehow does not like the <IfVersion> tags.

Puzzled...

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help