Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] [submodule] Remove duplicate call to set_rev_name

From: Heiko Voigt <hidden>
Date: 2016-06-15 22:57:51

Hi,

On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote:
set_rev_name is a possible expensive operation. If a submodule has
changes in it, set_rev_name was called twice.

Solution is to move set_rev_name so it's only called once, no matter the
codepath taken.
Looks good to me.

Cheers Heiko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help