Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2 0/3] Fix a race condition when reading loose refs

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:50

Jeff King [off-list ref] writes:
On Wed, Jun 19, 2013 at 08:36:25AM +0200, Michael Haggerty wrote:
quoted
I took Peff's suggestion to use gotos rather than an infinite loop in
the last patch, which means that there is no need for the old patch
03/04.
Thanks, this version looks good to me.

I'm sure the Pascal programmers of the world collectively sighed in
disgust at a code review requesting a for loop turn into a goto, but I
think it is more readable than the first version. :)

-Peff
Thanks, both.  Essentially the first two are the same from the
previous round, and the third one gives us "oops, unexpected
state---let's retry" in a more straight-forward way.

Looks very sensible; will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help