Re: [PATCH] fix "builtin-*" references to be "builtin/*"
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:48
Phil Hord [off-list ref] writes:
quoted hunk
diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index e831cc2..2483700 100644 --- a/Documentation/user-manual.txt +++ b/Documentation/user-manual.txt@@ -4256,7 +4256,7 @@ no longer need to call `setup_pager()` directly). Nowadays, `git log` is a builtin, which means that it is _contained_ in the command `git`. The source side of a builtin is -- a function called `cmd_<bla>`, typically defined in `builtin-<bla>.c`, +- a function called `cmd_<bla>`, typically defined in `builtin/<bla>.c`, and declared in `builtin.h`,
If we were to do this, we would need to update the "1.5.3 or newer" comment at the top of this file to "1.7.1 or newer" ;-). More seriously, it may be OK to say typically defined in `builtin/<bla.c>` (note that older versions of Git used to have it in `builtin-<bla>.c` instead), and declared in `builtin.h`. only here, and then apply your s|builtin-|builtin/| changes to the remainder of this file.
quoted hunk
diff --git a/builtin/help.c b/builtin/help.c index 062957f..ce7b889 100644 --- a/builtin/help.c +++ b/builtin/help.c@@ -1,5 +1,5 @@ /* - * builtin-help.c + * builtin/help.c * * Builtin help command */
As Jonathan said, dropping this line (and the line after it) would be a sane thing to do. Other than that, the patch looked good.