Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

Le 2013-06-18 12:47, Ramkumar Ramachandra a écrit :

Jorge-Juan.Garcia-Garcia@ensimag.imag.fr wrote:

quoted

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 9f46f22..87641bc 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh

@@ -1349,4 +1349,39 @@ test_expect_success $PREREQ 

'sendemail.aliasfile=~/.mailrc' '
        grep "^!someone@example\.org!$" commandline1
 '

-test_done
+test_expect_success $PREREQ 'setup expected-list' '
[...]
+test_expect_success $PREREQ 'use email list in --cc --to and --bcc' 
'

What is the meaning of this test?  It looks like you've run git
send-email twice in exactly the same way, and compared their outputs
(after smudging the unstable headers).

The first one uses one flag per email address, just like we had to do 
so far.
The second one uses one email-list per flag, which is the new feature 
we're introducing.
Then we compare the output of the two, and expect it to be exactly the 
same.

Shouldn't

$ git send-email --cc 'foo@example.com' --cc 'bar@example.com'

and

$ git send-email --cc 'foo@example.com, bar@example.com'

have the exact same effect ?
-- 
Mathieu Liénard--Mayor,
2nd year at Grenoble INP - ENSIMAG
(+33)6 80 56 30 02