Re: [PATCH v2 2/6] test-lib: refactor $GIT_SKIP_TESTS matching

Johannes Sixt [off-list ref] writes:

Am 6/17/2013 11:18, schrieb Thomas Rast:

quoted

+match_pattern_list () {
+	arg="$1"
+	shift
+	test -z "$*" && return 1
+	for pat
+	do
+		case "$arg" in
+		$pat)
+			return 0
+		esac
+	done
+	return 1
+}

Watch this failing test case:

   GIT_SKIP_TESTS="t950[012]" ./t3006-ls-files-long.sh

'pat' is too short and too sweet to be used as a shell variable name in a
library function. ;)

Gah!  Serves me right for not testing test-lib.  Thanks for noticing.

/me goes stand in the corner for a while

-- 
Thomas Rast
trast@{inf,student}.ethz.ch