Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH V2] git-remote-mediawiki: remove hardcoded version number in the test suite

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:45

benoit.person@ensimag.fr writes:
From: Benoit Person <redacted>

Updates the code to make it more easy to switch mediawiki version when
testing. Before that, the version number was partly hardcoded, partly
in a var.
This definitely goes in a good direction; you no longer have to
touch random lines in test-gitmw-lib.sh and what you have to edit 
is very much localized.

It seems t/test.config that is tracked is also designed to be
randomly edited to suit user's needs.

The patch does not make things any worse, but I would imagine that a
better longer term structure would be for contrib/mw-to-git/Makefile
to create contrib/mw-to-git/t/test.config by replacing variables in
contrib/mw-to-git/t/test.config-template, so that the user could say

	cd contrib/mw-to-git
        make MW_VERSION_MAJOR=1.20 MW_VERSION_MINOR=0 test

or something like that.

But of course, that is a totally unrelated issue.

Will apply.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help