Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] format-patch: remove existing output-directory

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:45

John Keeping [off-list ref] writes:
On Fri, Jun 14, 2013 at 06:45:19PM +0530, Ramkumar Ramachandra wrote:
quoted
John Keeping wrote:
quoted
I don't think this is the correct behaviour.  I can think of cases where
I would want to output multiple things into the same directory.
format.cleanOutputDirectory = true|false?
Maybe, but I was thinking of something more like:

    Output directory is not empty, use "--allow-non-empty-dir" if you
    really want to proceed.

Using that configuration variable lets someone shoot themselves in the
foot quite badly if they forget that they have set it and set the output
directory to somewhere containing important data.
Yes.  format.refuseToOutputToNonEmpty that defaults to false and
gives your error message is a sensible way to go.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help