Re: [PATCH 4/6] wt-status: remove unused field in grab_1st_switch_cbdata
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:44
Ramkumar Ramachandra [off-list ref] writes:
The struct grab_1st_switch_cbdata has the field "found", which is set in grab_1st_switch() when a match is found. This information is redundant and unused by any caller: the return value of the function serves to communicate this information anyway. Remove the field. Signed-off-by: Ramkumar Ramachandra <redacted> ---
Good.
quoted hunk
wt-status.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/wt-status.c b/wt-status.c index bf84a86..2511270 100644 --- a/wt-status.c +++ b/wt-status.c@@ -1035,7 +1035,6 @@ got_nothing: } struct grab_1st_switch_cbdata { - int found; struct strbuf buf; unsigned char nsha1[20]; };@@ -1059,7 +1058,6 @@ static int grab_1st_switch(unsigned char *osha1, unsigned char *nsha1, for (end = target; *end && *end != '\n'; end++) ; strbuf_add(&cb->buf, target, end - target); - cb->found = 1; return 1; }