Re: [PATCH 1/3] finish_copy_notes_for_rewrite(): Let caller provide commit message
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:43
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:43
Johan Herland [off-list ref] writes:
When copying notes for a rewritten object, the resulting notes commit would have the following hardcoded commit message: Notes added by 'git notes copy' This is obviously bogus when the notes rewriting is performed by 'git commit --amend'. Therefore, let the caller specify an appropriate notes commit message instead of hardcoding it. The above message is used for 'git notes copy', but when calling finish_copy_notes_for_rewrite() from builtin/commit.c, we use the following message instead: Notes added by 'git commit --amend' Cc: Thomas Rast <redacted> Signed-off-by: Johan Herland <redacted>
Makes sense. Thanks.