Re: [PATCH v4 09/31] git-remote-mediawiki: Change the behaviour of a split

On Tue, Jun 11, 2013 at 6:18 PM, Célestin Matte
[off-list ref] wrote:

A "split ' '" is turned into a "split / /", which changes its behaviour: the
old method matched a run of whitespaces (/\s*/), while the new one will match a
single whitespace, which is what we want here. Indeed, in other contexts,

I missed this nit in the last round. '/ /' will match a exactly one
space (not an arbitrary whitespace character), so this really should
be: s/single whitespace/single space/

changing split(' ') to split(/ /) could potentially be a regression, however,
here, when parsing the output of "rev-list --parents", whose output SHA-1's are
each separated by a single space, splitting on a single space is perfectly
correct.

Signed-off-by: Célestin Matte <redacted>
Signed-off-by: Matthieu Moy <redacted>