Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v4 2/2] status:introduce status.branch to enable --branch by default

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:57:41

Jorge-Juan.Garcia-Garcia@ensimag.imag.fr writes:
+test_expect_success '"status.branch=true" different from "--no-branch"' '
+	git -c status.branch=true status -s >actual &&
+	git status -s --no-branch  >expected_nobranch &&
Two nitpicks:

There are two spaces before >, there should be one.

If the first "git" command fails, then you fail to create
expected_nobranch and the other tests fail too. Creating
expected_nobranch before actual would solve this. You have the same
issue in PATCH 1/2.

With or without these fixed,

Reviewed-by: Matthieu Moy <redacted>

(both patches)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help