Re: [PATCH] t0005: skip signal death exit code test on Windows

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] t0005: skip signal death exit code test on Windows

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:39

Jeff King [off-list ref] writes:
I'm a little negative on handling just SIGTERM. That would make the test
pass, but does it really address the overall issue? To me, the
usefulness is having exit values with consistent meanings.
Yes.  Unless the goal is to give Windows port pratically the same
signal semantics as ports on other platforms, I do not think special
casing SIGTERM (unless it is a very common signal on Windows and
others are unlikely to be useful) buys us much.

Re: [PATCH] t0005: skip signal death exit code test on Windows

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:57:39

Am 6/9/2013 22:31, schrieb Junio C Hamano:
Jeff King [off-list ref] writes:
quoted
I'm a little negative on handling just SIGTERM. That would make the test
pass, but does it really address the overall issue? To me, the
usefulness is having exit values with consistent meanings.
Yes.  Unless the goal is to give Windows port pratically the same
signal semantics as ports on other platforms, I do not think special
casing SIGTERM (unless it is a very common signal on Windows and
others are unlikely to be useful) buys us much.
I'm thinking the same. And, no, SIGTERM is not very common on Windows.

-- Hannes

Re: [PATCH] t0005: skip signal death exit code test on Windows

From: Erik Faye-Lund <hidden>
Date: 2016-06-15 22:57:40

On Mon, Jun 10, 2013 at 7:30 AM, Johannes Sixt [off-list ref] wrote:
Am 6/9/2013 22:31, schrieb Junio C Hamano:
quoted
Jeff King [off-list ref] writes:
quoted
I'm a little negative on handling just SIGTERM. That would make the test
pass, but does it really address the overall issue? To me, the
usefulness is having exit values with consistent meanings.
Yes.  Unless the goal is to give Windows port pratically the same
signal semantics as ports on other platforms, I do not think special
casing SIGTERM (unless it is a very common signal on Windows and
others are unlikely to be useful) buys us much.
I'm thinking the same. And, no, SIGTERM is not very common on Windows.
I have no strong feelings on SIGTERM, but my knee-jerk reaction is the
same. AFAIK, the only issue we've seen with it has been this one,
which is synthetic.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help