Re: [PATCH 2/3] test: improve rebase -q test
From: Duy Nguyen <hidden>
Date: 2016-06-15 22:57:36
On Sat, Jun 8, 2013 at 3:32 AM, Felipe Contreras [off-list ref] wrote:
Let's show the output so it's clear why it failed.
I think you can always look into trash-directory.t3400 and figure why. But if you show this, I think you should use test_cmp to make it clear what is not wanted. Something like : >expected && test_cmp expected output.out
quoted hunk ↗ jump to hunk
Signed-off-by: Felipe Contreras <redacted> --- t/t3400-rebase.sh | 1 + 1 file changed, 1 insertion(+)diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh index b58fa1a..fb39531 100755 --- a/t/t3400-rebase.sh +++ b/t/t3400-rebase.sh@@ -185,6 +185,7 @@ test_expect_success 'default to @{upstream} when upstream arg is missing' ' test_expect_success 'rebase -q is quiet' ' git checkout -b quiet topic && git rebase -q master >output.out 2>&1 && + cat output.out && test ! -s output.out ' --1.8.3.698.g079b096 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Duy