Thread (16 messages) flat view 16 messages, 3 authors, 2016-06-15

Re: [PATCH 2/3] commit-queue: LIFO or priority queue of commits

From: Eric Sunshine <hidden>
Date: 2016-06-15 22:57:34

On Fri, Jun 7, 2013 at 1:11 AM, Junio C Hamano [off-list ref] wrote:
Traditionally we used a singly linked list of commits to hold a set
of in-flight commits while traversing history.  The most typical use
of the list is to insert commit that is newly discovered in it, keep
s/commit/a commit/

Also, "in it" is perhaps implied by "insert", so s/in it// may be appropriate.
it sorted by commit timestamp, pick up the newest one from the list,
and keep digging.  The cost of keeping the singly linked list sorted
is nontrivial, and this typical use pattern better matches a priority
queue.

Introduce a commit-queue structure, that can be used either as a
LIFO stack, or a priority queue.  This will be used in the next
patch to hold in-flight commits during sort-in-topological-order.

Signed-off-by: Junio C Hamano <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help