Re: [PATCH v5 1/7] add simple tests of consistency across rebase types

On Mon, Jun 3, 2013 at 11:15 PM, Johannes Sixt [off-list ref] wrote:

Am 6/4/2013 7:14, schrieb Martin von Zweigbergk:

quoted

On Mon, Jun 3, 2013 at 3:28 PM, Junio C Hamano [off-list ref] wrote:

quoted

quoted

+
+# checks that the revisions in "$2" represent a linear range with the
+# subjects in "$1"
+test_linear_range () {
+     ! { git log --format=%p "$2" | sane_grep " " ;} &&

An interesting way to spell:

    test $(git rev-list --merges "$2" | wc -l) = 0

Heh, true. I'll change that.

Then I think it would be even better written as

        revlist_merges=$(git rev-list --merges "$2") &&
        test -z "$revlist_merges"

so as not to ignore errors in the git invocation (and at least one less
fork()).

Done. I'll send it out in a day or two.