Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 6/6] completion: clarify ls-tree, archive, show completion

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:33

Ramkumar Ramachandra [off-list ref] writes:
Junio C Hamano wrote:
quoted
I think this is the same as 5/6 and better explained in a single
patch, as the rationale is the same: these commands can all take the
usual revs and then paths, so using misnamed complete_FILE helper is
wrong.

Mind if I squashed them together?
I'm okay with what you've queued in pu (sans some points raised by
SZEDER; looking into that), but you can squash them together if you
like.
In any case, I think it is sensible not to remove the _file
helper. We may want to fix it not to expand revname and do only the
pathname, but that is a separate issue from using _revlist_file for
the commands you updated completion for in these two patches.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help