Re: [PATCH 2/2] lookup_commit_reference_gently: do not read non-{tag,commit}

On Fri, May 31, 2013 at 4:22 AM, Jeff King [off-list ref] wrote:

On Thu, May 30, 2013 at 10:00:23PM +0200, Thomas Rast wrote:

quoted

lookup_commit_reference_gently unconditionally parses the object given
to it.  This slows down git-describe a lot if you have a repository
with large tagged blobs in it: parse_object() will read the entire
blob and verify that its sha1 matches, only to then throw it away.

Speed it up by checking the type with sha1_object_info() prior to
unpacking.

This would speed up the case where we do not end up looking at the
object at all, but it will slow down the (presumably common) case where
we will in fact find a commit and end up parsing the object anyway.

Perhaps turn "quiet" into a bitmap and only let git-describe do this?
--
Duy