Felipe Contreras wrote:
What's your objective? Block this patch from ever going in?
Not a single one of these comments makes a difference at all, all of
them can wait until after the patch is merged, many of them are a
matter of preferences, and some of them have already been addressed as
precisely that: disagreements in style.
You posted a patch, and I reviewed it. End of story. I never
explicitly or implicitly indicated that I want to block the patch, so
stop pulling stuff out of your arse.
If you don't want a review, write "DO NOT REVIEW" (or better yet,
don't hit my inbox). I'm not interested in wasting my time either.