Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

On Tue, May 28, 2013 at 9:19 PM, Duy Nguyen [off-list ref] wrote:

On Wed, May 29, 2013 at 10:41 AM, Duy Nguyen [off-list ref] wrote:

quoted

The changes in this area since 1.8.2.3 seem to be Karsten's (I'm not
blaming, just wanted to narrow down the problem). The patterns of
interest seem to be

!/bin
/bin/*
!/bin/brew

Without "!/bin" v1.8.3 seems to behave the same as v1.8.2.3.

Karsten, the block "/* Abort if the directory is excluded */" in
prep_exclude() seems to cause this. I think it goes through the
exclude patterns, hits "!/bin", believes the patterns do not make
sense in this context and throws all away. I think Øystein's case
falls into the same path. Commenting out the block seems to gain the
old behavior back (and probably breaks other stuff). Contrary to what
Junio said, I'm clueless about this. I wanted to read your series
through and eventually gave up. I think I now have the motivation to
look at it again this weekend.

The very first patch in the da/darwin series in "next" is one possible fix.

See 29de20504e9790785fe1698300755323f74972aa

    Makefile: fix default regex settings on Darwin

    t0070-fundamental.sh fails on Mac OS X 10.8:

        $ uname -a
        Darwin lustrous 12.2.0 Darwin Kernel Version 12.2.0:
        Sat Aug 25 00:48:52 PDT 2012;
        root:xnu-2050.18.24~1/RELEASE_X86_64 x86_64

        $ ./t0070-fundamental.sh -v
        fatal: regex bug confirmed: re-build git with NO_REGEX=1

    Fix it by using Git's regex library.

Does that patch also fix this issue?

Karsten, you mentioned that compiling without regex support fixes it for you.
Does the above commit in git.git's "next" branch fix it too?

If so, I think it would be worth merging this early part into a "maint" release.
--
David