Thread (11 messages) flat view 11 messages, 2 authors, 2016-06-15

Re: [PATCH v2 7/8] remote-bzr: reorganize the way 'wanted' works

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:28

Felipe Contreras [off-list ref] writes:
+    wanted = get_config('remote-bzr.branches').rstrip().split(', ')
Two minor nits and one design suggestion:

 - Why rstrip() not strip()?  It appears that this only is helping
   an end-user "mistake" like this:

	git config remote-bzr.branches 'trunk, devel, test '

   without helping people who have done this:

	git config remote-bzr.branches 'trunk,  devel, test'

 - Is

     git config remote-bzr.branches trunk,devel,test

   a grave sin?

   In other words, wouldn't we want something like this instead?

	map(lambda s: s.strip(), get_config('...').split(','))

 - Doesn't allowing multi-valued variable, e.g.

	[remote-bzr]
            branches = trunk
            branches = devel
            branches = test

   make it easier for the user to manage this configuration by
   e.g. selectively removing or adding tracked branches?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help