Re: [PATCH v4 14/21] remote-hg: show more proper errors

On Mon, May 27, 2013 at 11:30 AM, Antoine Pelisse [off-list ref] wrote:

Hey Felipe,
I know that has been integrated a while ago.

On Thu, Apr 11, 2013 at 2:23 PM, Felipe Contreras
[off-list ref] wrote:

quoted

When cloning or pushing fails, we don't want to show a stack-trace.

diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index ff89725..3ae3598 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg

@@ -284,11 +284,17 @@ def get_repo(url, alias):
     else:
         local_path = os.path.join(dirname, 'clone')
         if not os.path.exists(local_path):
-            peer, dstpeer = hg.clone(myui, {}, url, local_path, update=False, pull=True)
+            try:
+                peer, dstpeer = hg.clone(myui, {}, url, local_path, update=True, pull=True)
+            except:
+                die('Repository error')
             repo = dstpeer.local()

Can you explain why "update" went from False to True ? That can be a
problem if the repository is BIG (two working directories instead of
one can raise space issues).

The commit message is not so helpful here ;)

Good catch. It was probably a mistake. However, I already sent a patch
that overrides this so update=False again.

-- 
Felipe Contreras