Re: [PATCH 7/7] sha1_name: implement finding @{push}

Duy Nguyen wrote:

Then "show @{p}" should show the tip commit of rr/master, not the ref
name.

Yes, that is correct.

rev-parse (with an option, maybe) may be a better place for
this.

Er, no.  I actually want things like diff @{p}..HEAD.  I want it to be
a first-class revision, just like @{u}.

I did not expect @{p} to printf(). If it's part of get_sha1(), how can
it return an sha-1? And the cover letter said "7/7 is the meat". Not
very informative.

I also said sorry for the horrible mess ;)
Yes, it's obviously not supposed to print and die() with a "Done!":
this was a development session, and I hit send-email as soon as I got
the right output.  It's supposed to behave exactly like @{u} (failing
to resolve occasionally).