Thread (1 message) 1 message, 1 author, 2016-06-15

Re: What's cooking in git.git (May 2013, #05; Mon, 20)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:25

Michael J Gruber [off-list ref] writes:
Well, if we decide "showing blobs with textconv is fundamentally
different from showing diffs with textconv" then "--textconv" should not
apply any textconv filters on blobs unless the user has specified them
using a separate attribute (different from "diff").
I had an impression that the ship has already sailed wrt to "diff"
being pretty much interchangeable as "text" (or "non binary") in the
attribute system long time ago.
Therefore, I hesitate introducing the behavior of the current series.
For me, it would introduce something of a "mixed beast".

I wouldn't hesitate introducing "textconv on by default for blobs the
same as for diffs",
I would.  But I wouldn't for "the user asks for --textconv, the user
expects the blob shown with mangling", which sounds like a good
thing to do.

And there is anything wrong to refine later where exactly that
textconv filter is defined.  At this moment, "diff.textconv" is the
only place the user could even contemplate setting one, and there is
no risk for confusion.  "blob.textconv" can be introduced much later
when some users actually want to have a pair of different filters,
at that point "diff.textconv" will become a backward compatiblity
fallback for that filter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help