Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] Geolocation support

From: Antoine Pelisse <hidden>
Date: 2016-06-15 22:57:25

On Thu, May 23, 2013 at 10:45 AM, Ramkumar Ramachandra
[off-list ref] wrote:
Alessandro Di Marco wrote:
quoted
this is a hack I made a couple of years ago in order to store my current
location in git commits (I travel a lot and being able to associate a
place with the commit date helps me to quickly recover what were doing
at that time). Long story short, the screeenshot at
http://tinypic.com/r/wars40/5 shows the new gitk interface once this
patch has been integrated. Geolocation is controlled by two envvars
GIT_AUTHOR_PLACE and COMMITTER_PLACE, respectively. You can set them via
something like this:
Obviously very interesting.  Now, how do we mainline (parts of) this
feature?  I'll raise some questions here:
I'm really not convinced this kind of changes should make it into
Junio's tree (of course, he's the only one to decide). I really
believe this is a very specific solution to a very specific problem
(that is not for me to judge if the problem is real). Bloating the
commit object with this kind of information doesn't feel like a good
idea.
I think it could be nice to provide a simple shell script to build the
location, callable from a post-commit hook, to construct a
"geolocation" note. Gitk could be programmed to read the notes to get
the location, but once again, I'm not sure it should be mainlined.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help