Re: [RFC/PATCH] patch-ids: check modified paths before calculating diff

Jonathan Nieder [off-list ref] writes:

quoted

@@ -64,6 +199,13 @@ static struct patch_id *add_commit(struct commit *commit,
 	unsigned char sha1[20];
 	int pos;
 
+	if (no_add) {
+		if (collect_touched_paths(commit, ids, 1) < 0)
+			return NULL;

Ah, so this is what the "searching" does.

The existing "no_add" argument is very confusing (what does it mean to
add a commit without adding?),

Such a mode of operation is usually called "dry-run", no?