Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/6] test-lib: enable MALLOC_* for the actual tests

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:17

Thomas Rast [off-list ref] writes:
1b3185f (MALLOC_CHECK: various clean-ups, 2012-09-14) moved around the
MALLOC_CHECK_ and MALLOC_PERTURB_ assignments, intending to limit
their effect to only the test runs.  However, they were actually
enabled only during test cleanup.  Call setup/teardown_malloc_check
also around the evaluation of the actual test snippet.
Sorry about the breakage.
quoted hunk
Signed-off-by: Thomas Rast <redacted>
---
 t/test-lib.sh | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index ca6bdef..229f5f7 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -337,8 +337,10 @@ test_eval_ () {
 test_run_ () {
 	test_cleanup=:
 	expecting_failure=$2
+	setup_malloc_check
 	test_eval_ "$1"
 	eval_ret=$?
+	teardown_malloc_check
 
 	if test -z "$immediate" || test $eval_ret = 0 || test -n "$expecting_failure"
 	then
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help