Re: [RFC/PATCH 0/2] merge-base: add --merge-child option

On Sun, May 12, 2013 at 10:02:39PM -0700, Junio C Hamano wrote:

Kevin Bracey [off-list ref] writes:

quoted

On 12/05/2013 19:58, John Keeping wrote:

quoted

With the patch below, the --ancestry-path version drops to under 2
seconds.

I'm not sure if this is a good idea though.  It helps me say "I know
nothing that isn't on the ancestry path can be patch-identical, so don't
bother checking if it is" but it regresses users who want the full
cherry-pick check while only limiting the output.

Hmm. Should an excluded commit be a valid comparator? Is it
sensible/correct to show a left commit as "=" to a right commit that
has been excluded by the revision specifiers? Doesn't sound right to
me.

Neither to me.

OK.  I'll add some tests and send a proper patch once 1.8.3 is out of
the way.