Re: [PATCH v7 00/10] interactive git clean

2013/5/13 Matthieu Moy [off-list ref]:

Junio C Hamano [off-list ref] writes:

quoted

Cleaning all unneeded files inside a single interactive session
should *never* be the goal---that will lead to an over-engineered
design (e.g. switching "clean -x" flags in the middle? why?).  I
think Jiang's latest series is already way over-engineered,

I didn't read the end of the series in detail, but I tend to agree with
you. Maybe it's time to remember the YAGNI principle, and keep the
number of options small at least for now (e.g. drop 11/12 git-clean: add
toggle flags interactive action). When users (including us) will have
used "git clean -i" for a while, we'll have a better idea of what is
really needed.

My initial intention for flags toggle is for git newbies, who are not clear
about how to use -x/-d/-X/-ff options. I feel it may have values for these
people. But since most people feel it may bring trouble, I can withdraw
patch 9/12, 10/12, and 11/12.

Another improvement I want to hear your opinions. When the user execute
"git clean --interactive --dry-run", the current implement is ignore the
"--interactive" option, and do dry-run only. How about we combine them
together? First show the user the interactive interface, and when user
choose to clean, do cleaning in dry-run mode.

-- 
Jiang Xin
http://www.worldhello.net/