Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] patch-ids.c: cache patch IDs in a notes tree

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:13

John Keeping [off-list ref] writes:
quoted
But it is not a big problem.  Either 3-way merge notices that there
is nothing new, or you get a conflict and have chance to inspect
what is going on.
It's not a problem here, but false negatives would be annoying if you're
looking at "git log --cherry-mark".
The primary thing to notice is that it is not a new problem with or
without the caching layer.  As Linus mentioned how patch-ids are
computed by ignoring offsets and whitespaces, the filtering is done
as a crude approximation and false negatives are part of design, so
making the cache more complex by recording hash of the binary and/or
options used to compute misses the fundamental.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help