Re: [PATCH v7 03/10] Add colors to interactive git-clean

Jiang Xin [off-list ref] writes:

 * color.interactive.<slot>: Use customized color for interactive
   git-clean output (like git add --interactive). <slot> may be
   prompt, header, help or error.

This should go to the documentation (a short summary is welcome in the
commit messages in addition, but users won't read this...)

+	if (!prefixcmp(var, "color.interactive.")) {
+		int slot = parse_clean_color_slot(var, 18);

For readability and maintainability: please use
strlen("color.interactive."), not 18.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

2013/5/13 Matthieu Moy [off-list ref]:

Jiang Xin [off-list ref] writes:

quoted

 * color.interactive.<slot>: Use customized color for interactive
   git-clean output (like git add --interactive). <slot> may be
   prompt, header, help or error.

This should go to the documentation (a short summary is welcome in the
commit messages in addition, but users won't read this...)

quoted

+     if (!prefixcmp(var, "color.interactive.")) {
+             int slot = parse_clean_color_slot(var, 18);

For readability and maintainability: please use
strlen("color.interactive."), not 18.

Feel like conventional:

    git grep -C2 prefixcmp builtin/apply.c builtin/archive.c
builtin/branch.c builtin/checkout.c

But maybe 18 characters are too long. ;-)


-- 
Jiang Xin
http://www.worldhello.net/