Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCHv3 3/7] show: honor --textconv for blobs

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:13

Jeff King [off-list ref] writes:
On Fri, May 10, 2013 at 11:04:01AM -0700, Junio C Hamano wrote:
quoted
One thing to notice is that those accessing rev->pending before
calling prepare_revision_walk(), as opposed to those receiving
objects in rev->commits via get_revision(), are the only ones that
care about the context and wants to act differently depending on
where these came from and how they were specified.

That suggests at least two possibilities to me:

 - Perhaps we can place the context in rev->pending and clear them
   when prepare_revision_walk() moves them to rev->commits, without
   introducing rev->keep_object_context?

 - Perhaps instead of extending object-array, we can move this kind
   of information to rev_cmdline and enrich that structure?
Without looking too closely to see whether it is feasible, I would think
the latter would end up being much more elegant, since I think it
already deals with some allocation issues already.
Yeah. I am fairly reluctant to apply a change that makes entries in
object-array larger.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help