Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Bug: git-p4: Sometimes p4 generates Windows-style output on OS X

From: David Foster <hidden>
Date: 2016-06-15 22:57:09

I've observed that the p4 command that git-p4 delegates to occasionally 
outputs Windows-style line endings even on the OS X platform. When this 
happens, git-p4 gets very confused and crashes out.

I've attached a patch which seems to fix the issue in my case. Now this 
patch is a pretty bad hack, and I don't recommend that it be accepted 
as-is. It is just a starting point.

A real fix would determine in advance whether Perforce was going to emit 
Windows-style output. Since I don't know the circumstances under which 
this happens on non-Windows platforms, I can't provide a better patch. 
Someone who has intimate knowledge of p4's operating modes would be best 
to examine what's really going on with p4.

P.S. In case it matters, I am not subscribed to this mailing list, so 
you will need to CC me for any replies to reach me.

---
David Foster
http://dafoster.net/

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help