Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v4 3/3] Add colors to interactive git-clean

From: Jiang Xin <hidden>
Date: 2016-06-15 22:57:07

2013/5/2 Matthieu Moy [off-list ref]:
Jiang Xin [off-list ref] writes:
quoted
Show help, error messages, and prompt in colors for interactive
git-clean.
I find the red WARNING a bit agressive. Also, the NOTE: is the same
color as the WARNING, hence visually similar. I first thought it was
repeating the same message. I think it would make more sense to use
default color, black,
Will use new style -- CLEAN_COLOR_HEADER (GIT_COLOR_BOLD)
as header for interactive git-clean (i.e.  WARNING)
for the NOTE, by analogy with "git add -p" which
uses it for patch hunk headers (somehow, this is the question you're
replying to after the blue prompt below).
I agree. NOTE should only be displayed once, and will be fixed
in patch 3/1 of next reroll.

--
Jiang Xin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help