Re: [PATCH 1/2] help: add help_unknown_ref

Am 01.05.2013 21:55, schrieb Vikrant Varma:

On 01-05-2013 17:53, Ramkumar Ramachandra wrote:

quoted

Vikrant Varma wrote:

quoted

+void help_unknown_ref(const char* ref) {
+        int i;
+        struct similar_ref_cb ref_cb;
+        ref_cb.similar_refs = (struct string_list)STRING_LIST_INIT_NODUP;

Why are you casting STRING_LIST_INIT_NODUP?

quoted

+        ref_cb.base_ref = ref;

ref_cb.similar_refs has already been defined. The compiler won't let me
assign to it unless I cast first. However, I think compound literals are
a C99/gcc feature. Is this better?

    struct similar_ref_cb ref_cb = {ref, STRING_LIST_INIT_NODUP};

No. There are compilers that can initialize a struct only with constant
data, but ref is not a constant.

-- Hannes