Re: [PATCH v2 3/6] sha1_name: avoid Yoda conditions

Junio C Hamano [off-list ref] writes:

Felipe Contreras [off-list ref] writes:

quoted

On Tue, Apr 30, 2013 at 5:13 PM, Junio C Hamano [off-list ref] wrote:

quoted

Felipe Contreras [off-list ref] writes:

quoted

On Tue, Apr 30, 2013 at 5:00 PM, Junio C Hamano [off-list ref] wrote:

quoted

What is a Yoda condition?

---
Using if (constant == variable) instead of if (variable == constant),
like if (4 == foo).

Because it's like saying "if blue is the sky" or "if tall is the man".

That is an invalid analogy, as the sentences do not make sense.

A much better explanation I heard on this list is that people do not
say "If 1 is smaller than the number of your wives, you have a big
problem".

I actually was not asking why people find the convention to visually
align comparison with number lines unusual. We discussed this style
long time ago on this list.  I haven't heard the "Yoda condtion"
expression and was asking about the "Yoda" part.

It's popular culture.

http://en.wikipedia.org/wiki/Yoda

I know who Yoda is.  What I was puzzled with was what it has to do
with "if blue is the sky" (which is a bad analogy for "if (0 < len)"
anyway)?

I found http://de.wikipedia.org/wiki/Yoda_Conditions which does not
seem to have many other languages.

No need to reply, thanks.