Re: [PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static

Ramsay Jones [off-list ref] writes:

However, I'm always a little wary when I hear someone say "this may be
useful to others in the future, so lets do X to make it easier ...".
I have noticed that, much more often than not, that future user never
does materialise ... ;-)

I do not think you are reading the reason for the function
correctly.  It is not "We may find it useful elsewhere".

It is "We knew Windows benefits from having a 'quick, incorrect, but
the incorrectness happens not matter to the caller' hack, and we
used to use it everywhere.  But we identified one location we need
to disable the hack for correctness, hence this 'slow-but-correct'
function.  There may still be other places that needs fixing by
calling it".