Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] stash: tighten IS_STASH_LIKE logic

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:55

Ramkumar Ramachandra [off-list ref] writes:
Junio C Hamano wrote:
quoted
The risk of actually closing the door for future developers.  That
is a downside of this patch, if we were to apply it.
Okay, no issues.  Drop it.

Consider documenting the fact that IS_STASH_LIKE is merely a
contextual synonym for IS_MERGE_COMMIT somewhere though.
Documenting what IS_STASH_LIKE means and what it is meant to be used
for would add a lot of value, if it is not done already, but I doubt
it adds much value to document that it _happens to be implemented_
as "is it a merge commit?" in the current version.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help