Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2 3/6] transport-helper: clarify pushing without refspecs

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:54

Eric Sunshine [off-list ref] writes:
quoted
+       grep "remote-helper doesn.t support push; refspec needed" error
Is "doesn.t" intentional? It certainly works by accident in grep, but
did you mean s/doesn.t/doesn't/ ?
The pattern matching the expected string is not by accident, but by
design.

It of course can be made more strict to reject "doesnot" and require
"doesn't" by doing something like this:

       grep "remote-helper doesn'\''t support push; refspec needed" error

but at some point, it simply stops being worth it to tighten the
pattern.

For that matter, it could be as loose as

	grep "support push; refspec needed" error

if you know the string is unique enough.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help