Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3 10/13] pretty: add %C(auto) for auto-coloring

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:52

Duy Nguyen [off-list ref] writes:
quoted
This is to handle a corrupt input, e.g. "%C(auto)%Cbleu%H" where
(perhaps deprecated) "%Cblue" is misspelled, and parse_color()
returns 0 without consuming any byte.

Does it make sense not to turn auto off in such a case?
We don't have any mechanism to report invalid %C. Instead we let them
through as literals. If they are literals, they should not have any
side effects. So I think it makes sense not to turn off things.
Oh, you are right.  Thanks for a dose of sanity.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help