Thread (1 message) 1 message, 1 author, 2016-06-15

Re: What's cooking in git.git (Apr 2013, #05; Mon, 15)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:52

Thomas Rast [off-list ref] writes:
The warning triggers in some cases where it shouldn't, relating to
submodules:

  $ git submodule add gitosis@git.csa.inf.ethz.ch:domjudge.git domjudge
  Adding existing repo at 'domjudge' to the index
  warning: In Git 2.0, 'git add <pathspec>...' will also update
  the index for paths removed from the working tree that match
  the given pathspec. If you want to 'add' only changed
  or newly created paths, say 'git add --no-all <pathspec>...' instead.
Good one.  So "add" used internally there needs to say --no-add?
It also seems to hint that the problem is with giving a 'pathspec', but
in fact in the case of a "proper" pathspec (that isn't an existing path)
it does *not* trigger, even though it probably should:
We have seen users who explicitly say:

	git add dir

after removing dir/del and adding dir/ins got surprised that we do
not notice removal of dir/del without "add -A".  And it is fairly
straight-forward to check and warn for such a case.
That's of course assuming that you want to unconditionally make -A the
default.
I thought what the warning text says is what we decided to do
eventually.  Not "unconditionally", but "with <pathspec>", but not
"only with pathspec that exactly matches an existing path".  It
appears that we would better discuss and decide such details
further, so let's revert the "warn early" bits from master and kick
the topic back.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help