Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

On Mon, Apr 15, 2013 at 11:00 PM, Junio C Hamano [off-list ref] wrote:

Junio C Hamano [off-list ref] writes:

quoted

Jonathan Nieder [off-list ref] writes:

quoted

If you try this:

 1. Install Git for Windows (from the msysgit project)
 2. Put

     [core]
             autocrlf = false
             eol = native

    in your .gitconfig.
 3. Clone a project with

     *.txt text

    in its .gitattributes.

Then with current git, any text files checked out have LF line
endings, instead of the expected CRLF.

Cc: Johannes Schindelin <redacted>
Cc: Johannes Sixt <redacted>
Signed-off-by: Jonathan Nieder <redacted>
---
Eyvind Bernhardsen wrote:

quoted

Introduce a new configuration variable, "core.eol", that allows the user
to set which line endings to use for end-of-line-normalized files in the
working directory.  It defaults to "native", which means CRLF on Windows
and LF everywhere else.

The following fixup has been sitting in my tree (but not tested on
Windows) for a couple of weeks.  Sensible?

I don't know what the right choice for Cygwin is; probably LF unless
there is some way to detect the systemwide setting at run time.

Has anybody in Windows land any input?  I don't think what I do before
1.7.3 in my tree would matter much, so I am not applying this myself.

Pinging MsysGit folk again ...

This is absolutely the right thing to do. However, stuff have changed
a bit since the patch was written; this change now needs to go in
config.mak.uname instead of config.mak.