Re: [PATCH] bisect: Store first bad commit as comment in log file
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:50
Torstein Hegge [off-list ref] writes:
quoted hunk
When bisect successfully finds a single revision, the first bad commit should be shown to human readers of 'git bisect log'. This resolves the apparent disconnect between the bisection result and the log when a bug reporter says "I know that the first bad commit is $rev, as you can see from $(git bisect log)". Signed-off-by: Torstein Hegge <redacted> --- I don't know how useful the added test is, I didn't find any existing tests that looks at the comment parts of bisect log. git-bisect.sh | 8 +++++++- t/t6030-bisect-porcelain.sh | 18 ++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-)diff --git a/git-bisect.sh b/git-bisect.sh index 99efbe8..c58eea7 100755 --- a/git-bisect.sh +++ b/git-bisect.sh@@ -311,7 +311,13 @@ bisect_next() { res=$? # Check if we should exit because bisection is finished - test $res -eq 10 && exit 0 + if test $res -eq 10 + then + bad_rev=$(git show-ref --hash --verify refs/bisect/bad) + bad_commit=$(git show-branch $bad_rev) + echo "# first bad commit: $bad_commit" >>"$GIT_DIR/BISECT_LOG"
As this is "# commented out", replaying will safely ignore this new record, so this should be safe.