[PATCH 31/33] pack_one_ref(): do some cheap tests before a more expensive one
From: Michael Haggerty <hidden>
Date: 2016-06-15 22:56:49
Subsystem:
the rest · Maintainer:
Linus Torvalds
Signed-off-by: Michael Haggerty <redacted> --- refs.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/refs.c b/refs.c
index 923d34f..361a28f 100644
--- a/refs.c
+++ b/refs.c@@ -2005,16 +2005,15 @@ static int pack_one_ref(struct ref_entry *entry, void *cb_data) { struct pack_refs_cb_data *cb = cb_data; enum peel_status peel_status; - int is_tag_ref; + int is_tag_ref = !prefixcmp(entry->name, "refs/tags/"); - /* Do not pack symbolic or broken refs: */ - if ((entry->flag & REF_ISSYMREF) || !ref_resolves_to_object(entry, 0)) + /* ALWAYS pack refs that were already packed or are tags */ + if (!((cb->flags & PACK_REFS_ALL) || is_tag_ref || + (entry->flag & REF_ISPACKED))) return 0; - is_tag_ref = !prefixcmp(entry->name, "refs/tags/"); - /* ALWAYS pack refs that were already packed or are tags */ - if (!(cb->flags & PACK_REFS_ALL) && !is_tag_ref && - !(entry->flag & REF_ISPACKED)) + /* Do not pack symbolic or broken refs: */ + if ((entry->flag & REF_ISSYMREF) || !ref_resolves_to_object(entry, 0)) return 0; peel_status = peel_entry(entry, 1);
--
1.8.2.1