Re: [PATCH v3 3/7] completion: add new __gitcompadd helper

Felipe Contreras [off-list ref] writes:

On Fri, Apr 12, 2013 at 12:55 PM, Junio C Hamano [off-list ref] wrote:

quoted

Felipe Contreras [off-list ref] writes:

quoted

quoted

 }

 # Generates completion reply with compgen from newline-separated possible

@@ -1820,7 +1823,7 @@ _git_config ()
              local remote="${prev#remote.}"
              remote="${remote%.fetch}"
              if [ -z "$cur" ]; then
-                     COMPREPLY=("refs/heads/")
+                     __gitcompadd "refs/heads/"

I am not sure about this one, though.

Other callers took pains to protet against triggering unset variable
references by using ${1-} instead of ${1}.  Shouldn't this caller be
passing three empty strings?

Perhaps, or perhaps we were being too careful before: 'compgen -W foo'
is the same as 'compgen -W foo -S "" -P "" -- ""'.

Yes, they are the same (otherwise this patch would not be valid),
but that is not what i was wondering about.