Re: [PATCH v4] transport-helper: report errors properly

On Wed, Apr 10, 2013 at 04:13:20PM -0700, rh wrote:

quoted

+++ b/transport-helper.c

@@ -54,7 +54,7 @@ static int recvline_fh(FILE *helper, struct strbuf

*buffer) if (strbuf_getline(buffer, helper, '\n') == EOF) {
 		if (debug)
 			fprintf(stderr, "Debug: Remote helper quit.
\n");
-		exit(128);
+		die("Reading from remote helper failed");

Do I read this correctly?  If I'm in debug mode the remote helper quit
but if not in debug mode it failed?  Debuggers never fail they only quit!

In debug mode, it prints both messages. The debug version is superfluous
at this point, though, and we can probably just drop it.

-Peff