On Wed, Apr 10, 2013 at 04:22:57PM +0200, Torsten Bögershausen wrote:
Running make inside contrib/remote-helpers may fail in "test-lint-duplicates"
This was because the regexp checking for duplicate numbers strips everything
after the first "-" in the filename, including the prefix.
As a result, 2 pathnames like
"xxxx/contrib/remote-helpers/test-XX.sh" and
"xxxx/contrib/remote-helpers/test-YY.sh"
are both converted into
"xxxx/contrib/remote", and reported as duplicate.
Improve the regexp:
- strip the leading path and look only at the basename
- only look at files which have tNNNN- (where N stand for a digit) in the name
Signed-off-by: Torsten Bögershausen <redacted>
---
Yeah, I think this is fine. Though note that we already have Felipe's
patch to just set TEST_LINT explicitly, so I think it is a non-issue
now.
-Peff